Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameter/serialization in test_manual_schedule_trigger.py #2568

Merged

Conversation

Hakuyume
Copy link
Member

initial_iteration is no longer needed.

@mitmul mitmul self-assigned this Apr 17, 2017
@mitmul
Copy link
Member

mitmul commented Apr 17, 2017

LGTM

@okuta okuta added the cat:test Test or CI related. label Apr 18, 2017
@okuta okuta added this to the v1.24.0 milestone Apr 18, 2017
@Hakuyume Hakuyume changed the title Remove unused parameter in test_manual_schedule_trigger.py Remove unused parameter/serialization in test_manual_schedule_trigger.py May 2, 2017
@Hakuyume
Copy link
Member Author

Hakuyume commented May 2, 2017

updater serialization has no effect on tests of ManualScheduleTrigger

@mitmul mitmul changed the base branch from master to _v2 May 25, 2017 13:55
@mitmul mitmul modified the milestones: v2.0.0, v1.24.0 May 25, 2017
@delta2323 delta2323 self-assigned this May 25, 2017
@mitmul mitmul removed this from the v2.0.0 milestone Jun 1, 2017
@Hakuyume
Copy link
Member Author

Hakuyume commented Jun 6, 2017

I think this PR is not merged. Is there any problem?

@delta2323
Copy link
Member

Sorry, we could not work on this PR to concentrate on the release of v2 tasks. @mitmul could you check the PR again?

@mitmul
Copy link
Member

mitmul commented Jun 12, 2017

OK, sorry I'll check this again soon.

@mitmul
Copy link
Member

mitmul commented Jun 12, 2017

Now master branch is broken, so please wait a little for master to be fixed.

@delta2323 delta2323 removed their assignment Jun 19, 2017
@mitmul mitmul changed the base branch from _v2 to master June 19, 2017 06:25
@mitmul mitmul merged commit d592c4a into chainer:master Jun 22, 2017
@beam2d beam2d modified the milestone: Closed issues and PRs Sep 12, 2017
@Hakuyume Hakuyume deleted the improve-tests-of-manual-schedule-trigger branch May 21, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants