New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fuse with *args without input_num #2598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except comments
|
||
@cupy.fuse(input_num=n) | ||
def _check(self, func, n, gen, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this code?
def check(self, func, n, gen, *args):
self._check(func, n, gen, args, True)
def _check(self, func, n, gen, args, omit_nin):
nin = n if not omit_nin else None
self._check_reduce(func, n, reduce_f, gen, *args, omit_nin=True) | ||
self._check_reduce(func, n, reduce_f, gen, *args, omit_nin=False) | ||
|
||
def _check_reduce(self, func, n, reduce_f, gen, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Thank you for review! Fixed it. |
Fix #2594