Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code to fetch the SVHN dataset #2923

Merged
merged 8 commits into from
Aug 24, 2017
Merged

Code to fetch the SVHN dataset #2923

merged 8 commits into from
Aug 24, 2017

Conversation

rcalland
Copy link
Contributor

SVHN is very similar to MNIST. I added code that will download and create datasets for train and test samples the same way get_mnist() does.

This code requires scipy in order to read the matlab format that files are officially provided in.

SVHN is very similar to MNIST. I added code that will download and create datasets for train and test samples the same way `get_mnist()` does.
@rcalland rcalland changed the title Fetch the SVHN dataset Code to fetch the SVHN dataset Jun 28, 2017
@mattya mattya self-assigned this Jun 29, 2017
@mattya
Copy link
Contributor

mattya commented Jun 29, 2017

Thank you for the PR!
I have two comments.

@rcalland
Copy link
Contributor Author

rcalland commented Jul 4, 2017

The SVHN website says:
10 classes, 1 for each digit. Digit '1' has label 1, '9' has label 9 and '0' has label 10.
which I guess is less confusing, how about switching to that system?

@rcalland
Copy link
Contributor Author

rcalland commented Jul 4, 2017

I just realised I misunderstood slightly the label definitions on the website, and so simply setting digit "0" from label 10 to 0 makes everything sensible!

@mattya
Copy link
Contributor

mattya commented Jul 6, 2017

Thank you for the update.
It seems there are some flake8 errors in __init__.py and svhn.py. Could you fix them?

@mattya
Copy link
Contributor

mattya commented Jul 13, 2017

There are still following flake8 errors

.\chainer\datasets_init_.py:6:1: H306 imports not in alphabetical order (chainer.datasets.svhn, chainer.datasets.ptb)
.\chainer\datasets_init_.py:21:1: H306 imports not in alphabetical order (chainer.datasets.svhn.get_svhn, chainer.datasets.ptb.get_ptb_words)

@rcalland
Copy link
Contributor Author

My version of flake8 didn't show those errors. Fixed.

@mattya
Copy link
Contributor

mattya commented Jul 24, 2017

Sorry for late reply, current CI is failing because scipy is not in the default dependency.
Could you add scipy availability check like this? https://github.com/cupy/cupy/blob/d7ad0d34f77de5b111807c0c1998176e9ab7e59a/cupy/sparse/csc.py#L1

@mattya
Copy link
Contributor

mattya commented Aug 24, 2017

Thank you for fixing and sorry for late reply.
LGTM!

@mattya mattya merged commit f8e6825 into chainer:master Aug 24, 2017
@mattya mattya added this to the v3.0.0rc1 milestone Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants