Improve docs of links/connection/lstm #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta2323
added
cat:document
mitmul
requested changes
Aug 21, 2017
chainer/links/connection/lstm.py
Outdated
| There are several ways to make a LSTM link. | ||
|
|
||
| Let a two-dimensional input array :math:`x`, a cell state array | ||
| :math:`h`, and the output array of the previous step :math:`h` be: |
There was a problem hiding this comment.
The cell state array and the output array of the previous step are not used the following part, so I think the part which describes about these two variables should be removed.
|
@keisuke-umezawa Could you rebase it to the current master? |
keisuke-umezawa
force-pushed
the
improve-docs-of-lstm-link
branch
from
5fc96a6
to
6037984
Compare
|
@mitmul I rebased and followed review. |
|
Jenkins, test this please |
|
LGTM |
mitmul
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR for improving docs of functions/links. Related issue: #2182
Modified functions/links: