Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] interval_trigger using previous_epoch_detail #3151

Closed
wants to merge 3 commits into from

Conversation

delta2323
Copy link
Member

@delta2323 delta2323 commented Aug 15, 2017

Backport of #2484

Be careful that this PR changes existing APIs. Specifically, this PR:

  • adds iter_per_epoch argument with the default value to get_trainer_with_mock_updater.
  • adds serialize method to IntervalTrigger.

As we declared in the contribution guide, we do not add any feature to revision updates basically. But as this PR introduced new features to fix bugs in stable versions. We propose to backport the PR. In order to make it clear that newly-added APIs are not documented (therefore not officially supported), we do not add documents to these APIs intentionally.

delta2323 and others added 2 commits August 15, 2017 15:34
…previous-epoch-detail

interval_trigger using previous_epoch_detail
@delta2323 delta2323 added backport Pull request that is backported from a more recent version. cat:bug Bug report or fix. labels Aug 15, 2017
@delta2323 delta2323 changed the title [WIP] [backport] interval_trigger using previous_epoch_detail [backport] interval_trigger using previous_epoch_detail Aug 15, 2017
@delta2323 delta2323 added this to the v2.0.3 milestone Aug 15, 2017
@unnonouno
Copy link
Member

Check travis

@niboshi niboshi added the st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. label Sep 4, 2017
@delta2323 delta2323 added st:ready-for-review and removed st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. labels Sep 5, 2017
@gwtnb gwtnb removed this from the v2.1.0 milestone Sep 12, 2017
@niboshi
Copy link
Member

niboshi commented Sep 13, 2017

Closing, as we won't backport to v2 any more.

@niboshi niboshi closed this Sep 13, 2017
@niboshi niboshi added this to the Closed issues and PRs milestone Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull request that is backported from a more recent version. cat:bug Bug report or fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants