Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check deprecation warining in Travis #3157

Merged

Conversation

unnonouno
Copy link
Member

I changed warnings configuration to check DeprecationWarnings. Note that some ignore configurations are required because Python itself shows DeprecationWarnings.

@unnonouno unnonouno added the cat:test Test or CI related. label Aug 15, 2017
@unnonouno unnonouno force-pushed the travis-check-deprecation-warining branch 2 times, most recently from d2a8733 to f58a491 Compare August 17, 2017 01:26
@unnonouno unnonouno force-pushed the travis-check-deprecation-warining branch from f58a491 to 1c8d992 Compare August 30, 2017 11:20
@unnonouno unnonouno force-pushed the travis-check-deprecation-warining branch 3 times, most recently from 5967654 to 9919b36 Compare September 10, 2017 17:00
@unnonouno unnonouno changed the title [WIP] Check deprecation warining in Travis Check deprecation warining in Travis Sep 10, 2017
@unnonouno unnonouno added the st:blocked-by-another-pr State indicating that another ticket is preventing this ticket from being closed/merged. label Sep 10, 2017
@unnonouno
Copy link
Member Author

merge #3363 before this pr.

@unnonouno unnonouno force-pushed the travis-check-deprecation-warining branch from 9919b36 to f1ffd19 Compare September 11, 2017 04:48
@delta2323 delta2323 added st:ready-for-review and removed st:blocked-by-another-pr State indicating that another ticket is preventing this ticket from being closed/merged. labels Sep 11, 2017
@delta2323
Copy link
Member

jenkins, test this please.

@delta2323 delta2323 self-assigned this Sep 11, 2017
@delta2323
Copy link
Member

jenkins, test this please

@delta2323
Copy link
Member

jenkins, test this please.

@delta2323
Copy link
Member

LGTM

@delta2323 delta2323 merged commit 1b886ba into chainer:master Oct 6, 2017
@delta2323 delta2323 added this to the v4.0.0a1 milestone Oct 6, 2017
@delta2323
Copy link
Member

Should we backport this PR?

@unnonouno unnonouno deleted the travis-check-deprecation-warining branch October 6, 2017 00:42
@unnonouno
Copy link
Member Author

yes, please

takagi pushed a commit to takagi/chainer that referenced this pull request Oct 28, 2017
…on-warining

Check deprecation warining in Travis
@takagi takagi added the to-be-backported Pull request that should be backported. label Oct 28, 2017
@takagi
Copy link
Member

takagi commented Oct 28, 2017

This PR is missed to be backported. I have posted #3721 .

takagi pushed a commit to takagi/chainer that referenced this pull request Oct 28, 2017
…on-warining

Check deprecation warining in Travis
takagi pushed a commit to takagi/chainer that referenced this pull request Oct 28, 2017
…on-warining

Check deprecation warining in Travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants