New style convolution_2d and deconvolution_2d #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beam2d
added
backport
okuta
reviewed
Aug 20, 2017
| else: | ||
| return func(x, W, b) | ||
| func = Deconvolution2DFunction(stride, pad, outsize) | ||
| args = x, W |
There was a problem hiding this comment.
How about following code?
if b is None:
args = x. W
else:
args = x, W, b
27 tasks
beam2d
added
cat:feature
|
Please rebase or merge master |
|
LGTM except comment. |
beam2d
force-pushed
the
new-style-conv2d
branch
from
184423a
to
c75cd7b
Compare
|
Rebased. |
okuta
reviewed
Aug 24, 2017
| **kwargs): | ||
| cover_all = None | ||
| conv_desc = None | ||
| filter_desc = None |
There was a problem hiding this comment.
Why do you cache this descriptor?
There was a problem hiding this comment.
I didn't change the behavior of caching descriptors. Is it better to remove it?
There was a problem hiding this comment.
Note: the above change is just about the default values for these attributes.
|
Removed the descriptors. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new style version of
F.convolution_2dandF.deconvolution_2d. These functions are now twice differentiable (but not three times differentiable until some functions used in backward, e.g.F.sum, support double backward).This PR depends on #3096, and is a part of #3147.