New style mean_squared_error #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
unnonouno
requested changes
Aug 27, 2017
| def backward(self, indexes, gy): | ||
| x0, x1 = self.get_retained_inputs() | ||
| ret = [] | ||
| diff = x0 - x1 |
There was a problem hiding this comment.
diff is calculated here. You don't need to store self.diff in forward_xxx.
| @@ -1,10 +1,11 @@ | |||
| import numpy | |||
|
|
|||
| from chainer import function | |||
| from chainer import function_node | |||
| from chainer.functions.array import broadcast | |||
There was a problem hiding this comment.
Use chainer.functions.broadcast_to
|
Thank you for your review. Updated. |
unnonouno
approved these changes
Aug 28, 2017
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of #3147 and apply the new-style API to
mean_squared_error.