Fused LSTM grad-grad #3256
Merged
Fused LSTM grad-grad #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnonouno
force-pushed
the
lstm-fusion
branch
from
a6bd4fd
to
fee7d2d
Compare
unnonouno
added
cat:enhancement
|
jenkins, test this please. |
okuta
reviewed
Sep 19, 2017
| return cuda.fusion.tanh(x * half) * half + half | ||
|
|
||
|
|
||
| @cuda.fuse() |
There was a problem hiding this comment.
How about using input_num?
lstm_grad_grad will accept writable arguments.
@cuda.fuse(input_num=13)
def lstm_grad_grad(
c_prev, a, i, f, o, c, gc, gh, ggc_prev, gga, ggi, ggf, ggo,
gc_prev, ga, gi, gf, go, gc_next, ggc, ggh):There was a problem hiding this comment.
I wrote sample. That kernel will reduce array copy.
okuta
added
st:awaiting-author
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSTM grad-grad calls too many kernels. I used
cupy.fuseto combine them.Merge #3206 first.