Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test of to_gpu with Variable argument #3269

Merged
merged 2 commits into from Sep 3, 2017
Merged

Fix test of to_gpu with Variable argument #3269

merged 2 commits into from Sep 3, 2017

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Aug 29, 2017

Fixed a test of to_gpu with Variable argument.
Currently, ValueError: Unsupported dtype object is raised instead of TypeError.

@niboshi niboshi added cat:bug Bug report or fix. to-be-backported Pull request that should be backported. labels Aug 29, 2017
@okuta okuta self-assigned this Sep 3, 2017
@okuta okuta added this to the v3.0.0rc1 milestone Sep 3, 2017
@okuta
Copy link
Member

okuta commented Sep 3, 2017

LGTM!

@okuta okuta merged commit ef278de into chainer:master Sep 3, 2017
okuta added a commit to okuta/chainer that referenced this pull request Sep 3, 2017
@okuta
Merge pull request chainer#3269 from niboshi/fix-test-variable-to-gpu
7657a92 
Fix test of to_gpu with Variable argument
@okuta okuta mentioned this pull request Sep 3, 2017
Merged
@niboshi niboshi deleted the fix-test-variable-to-gpu branch June 12, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okuta okuta

Labels
cat:bug Bug report or fix. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v3.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niboshi @okuta