Delete redundant test settings for get_item #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyu2172
changed the title
niboshi
added
cat:test
|
jenkins, test this please |
niboshi
added
the
st:test-and-merge
|
LGTM! |
niboshi
added a commit
to niboshi/chainer
that referenced
this pull request
Sep 28, 2017
…t-tests Delete redundant test settings for get_item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug.
The option
dtypeis not used in the test functions.I don't think it is necessary to check for
int32, uint32, ulonglong, uint64because these dtypes are not differentiable.Also, the function
__getitem__andscatter_addare tested with these dtypes in tests for CuPy.