Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add higher-order derivative support of Chainer to the comparison table #3477

Merged
merged 5 commits into from Mar 30, 2018

Conversation

delta2323
Copy link
Member

This PR updates the comparison table to add partial support of higher-order derivative to the Chainer slot.

@delta2323 delta2323 added the cat:document Documentation such as function documentations, comments and tutorials. label Sep 30, 2017
@delta2323 delta2323 changed the title Update comparison table Add higher-order derivative support of Chainer to the comparison table Sep 30, 2017
@niboshi
Copy link
Member

niboshi commented Sep 30, 2017

How about writing a note describing why this is "partial"?

@niboshi niboshi added the to-be-backported Pull request that should be backported. label Sep 30, 2017
@niboshi niboshi added this to the v4.0.0a1 milestone Sep 30, 2017
@niboshi niboshi added the st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. label Oct 11, 2017
@gwtnb gwtnb removed this from the v4.0.0a1 milestone Oct 17, 2017
@delta2323
Copy link
Member Author

I added comments.

@niboshi niboshi removed the st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. label Dec 18, 2017
@Crissman
Copy link
Member

Crissman commented Mar 8, 2018

LGTM.

Copy link
Member

@mitmul mitmul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one comment.

@@ -37,8 +37,9 @@ This table compares Chainer with other actively developed deep learning framewor
.. [1] Define-by-run is in development as of June 2017 and tracked in `dmlc/mxnet#5705 <https://github.com/dmlc/mxnet/pull/5705>`_. It is also possible using the much slower MinPy extension.
.. [2] Symbolic autograd is in development as of June 2017 and tracked in `deeplearning4j/nd4j#1750 <https://github.com/deeplearning4j/nd4j/pull/1750>`_.
.. [3] Symbolic autograd is available only with ngraph backend (experimental).
.. [4] Nervana provides kernels that are meant to compete with cuDNN.
.. [5] Multiprocessing provides a significant performance improvement only for frameworks that use Python at runtime.
.. [4] Some functions do not support higher-order differentiation. See `chainer/chainer#2970 <https://github.com/chainer/chainer/pull/2970>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace this with #4449 ?

@delta2323
Copy link
Member Author

Thank you for your review. I applied your suggestion.

@Crissman Crissman assigned mitmul and unassigned Crissman Mar 16, 2018
@kmaehashi kmaehashi added this to the v5.0.0a1 milestone Mar 20, 2018
@mitmul
Copy link
Member

mitmul commented Mar 23, 2018

Jenkins, test this please

@mitmul
Copy link
Member

mitmul commented Mar 30, 2018

LGTM

@mitmul mitmul merged commit 90f50b0 into chainer:master Mar 30, 2018
kmaehashi pushed a commit to kmaehashi/chainer that referenced this pull request Apr 17, 2018
Add higher-order derivative support of Chainer to the comparison table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants