New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New style square function #3578
Conversation
a8af890
to
8038ddc
Compare
I got the situation. We don't need to keep Actually the number of places where the decorator is now used is only five, so would you make the decorator accept only I suppose it would be enough. |
We should follow API compat policy for |
Ok, thank you for confirmation! |
It would be more natural for Chainer to let master...takagi:fix-test-math-function Here How about this? |
Thank you for the suggestion, it looks good to me. |
I posted a PR to fix |
8038ddc
to
5ba8911
Compare
Rebased. |
LGTM! |
New style square function
This PR implements new style
square
function.I also fixed
unary_math_function_test
decorator to support testing FunctionNode.I think this is transitional; once #3499 got merged, it is better to rewrite tests with the new function test template.