Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix contribution guide for test framework change #3625

Merged
merged 4 commits into from Oct 28, 2017

Conversation

kmaehashi
Copy link
Member

As test framework is changed from nose to pytest, we need to update contrib guide.

This PR documents the behavior of new decorator proposed in #3624.

@kmaehashi kmaehashi changed the title [WIP] fix contribution guide for test framework change fix contribution guide for test framework change Oct 27, 2017
@kmaehashi kmaehashi added cat:document Documentation such as function documentations, comments and tutorials. st:ready-for-review to-be-backported Pull request that should be backported. labels Oct 27, 2017
@okuta okuta added this to the v4.0.0b1 milestone Oct 28, 2017
@okuta okuta self-assigned this Oct 28, 2017
@okuta
Copy link
Member

okuta commented Oct 28, 2017

LGTM!

@okuta okuta merged commit e04899d into chainer:master Oct 28, 2017
okuta added a commit to okuta/chainer that referenced this pull request Oct 28, 2017
fix contribution guide for test framework change
@kmaehashi kmaehashi deleted the fix-contrib-guide-pytest branch October 30, 2017 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants