add link to CuPy upgrade guide #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmaehashi
force-pushed
the
link-cupy-upgrade-guide
branch
from
5f0a104
to
d132d6c
Compare
niboshi
added
st:blocked-by-another-pr
delta2323
requested changes
Feb 5, 2018
docs/source/upgrade.rst
Outdated
| ------- | ||
|
|
||
| Chainer v4 requires CuPy v4 if you need GPU support. | ||
| Please see the `Upgrade Guide for CuPy v4 <https://docs.chainer.org/en/latest/upgrade.html#cupy-v4>`_ for details. |
There was a problem hiding this comment.
The link seems points to Chainer's document, not CuPy. Is that correct?
There was a problem hiding this comment.
Thanks, that was wrong. Fixed.
docs/source/upgrade.rst
Outdated
| ------- | ||
|
|
||
| Chainer v3 requires CuPy v2 if you need GPU support. | ||
| Please see the `Upgrade Guide for CuPy v2 <https://docs.chainer.org/en/latest/upgrade.html#cupy-v2>`_ for details. |
|
jenkins, test this please. |
|
Thank you for update. I'm thinking to merge this after cupy/cupy#884. |
kmaehashi
removed
the
st:blocked-by-another-pr
|
Jenkins, test this please. |
delta2323
approved these changes
Mar 3, 2018
|
LGTM |
delta2323
added a commit
to delta2323/chainer
that referenced
this pull request
Mar 14, 2018
add link to CuPy upgrade guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add link to CuPy upgrade guide from Chaier upgrade guide.
Depends on cupy/cupy#884.(merged)