Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation and examples #4208

Merged
merged 7 commits into from Jan 24, 2018
Merged

Update documentation and examples #4208

merged 7 commits into from Jan 24, 2018

Conversation

vilyair
Copy link
Contributor

@vilyair vilyair commented Jan 19, 2018 •
edited

In general, fix init_scope() and StandardUpdater, ParallelUpdater namespace problem in the documentation and examples, in addition to some wrong links in the document.

@vilyair vilyair changed the title Update documentation Update documentation and examples Jan 21, 2018
@niboshi
Copy link
Member

niboshi commented Jan 23, 2018

Jenkins, test this please.

@niboshi niboshi added st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. cat:document Documentation such as function documentations, comments and tutorials. cat:example Example, e.g. the MNIST example. labels Jan 23, 2018
@niboshi niboshi added this to the v4.0.0b4 milestone Jan 23, 2018
@niboshi
Copy link
Member

niboshi commented Jan 24, 2018

LGTM!
Thank you!

@niboshi niboshi merged commit 0080f6a into chainer:master Jan 24, 2018
@niboshi niboshi added the to-be-backported Pull request that should be backported. label Jan 24, 2018
niboshi added a commit to niboshi/chainer that referenced this pull request Jan 24, 2018
@niboshi
Merge pull request chainer#4208 from vilyaair/master
7701013 
Update documentation and examples
@niboshi niboshi mentioned this pull request Jan 24, 2018
Merged
niboshi added a commit to niboshi/chainer that referenced this pull request Jan 24, 2018
@niboshi
Merge pull request chainer#4208 from vilyaair/master
334ff39 
Update documentation and examples
@kmaehashi kmaehashi mentioned this pull request Feb 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
cat:document Documentation such as function documentations, comments and tutorials. cat:example Example, e.g. the MNIST example. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v4.0.0b4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vilyair @niboshi