Refactor test_batch_normalization #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
force-pushed
the
refactor-test-batch-normalization
branch
from
3391af7
to
2155c0a
Compare
niboshi
force-pushed
the
refactor-test-batch-normalization
branch
from
51fa215
to
1899ff3
Compare
kmaehashi
requested changes
Jan 25, 2018
|
|
||
|
|
||
| def _batch_normalization(expander, gamma, beta, x, mean, var): | ||
| def _to_noncontiguous(arrays): |
There was a problem hiding this comment.
I feel the name _to_noncontiguous is a bit misleading (as the resulting array is F-contiguous)
There was a problem hiding this comment.
I agree. _to_fcontiguous?
kmaehashi
added
the
st:test-and-merge
kmaehashi
approved these changes
Jan 25, 2018
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
test_batch_normalizationto usetesting.backend.inject_backend_tests.