Fix some inconsistency in gradient variable names. #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis failure seems unrelated to the PR. |
|
jenkins, test this please. |
toslunar
requested changes
Feb 15, 2018
chainer/functions/activation/tanh.py
Outdated
| y_mul_ggx = y * ggx | ||
| gx = -2 * gy * y_mul_ggx | ||
| ggy = ggx - y * y_mul_ggx | ||
| return gx, ggy |
There was a problem hiding this comment.
Could you keep the name grad_y, since it's not a gradient of x?
There was a problem hiding this comment.
Yes. Oh, TanhGrad is defined as a function of y, not x!
| g, = grad_outputs | ||
| return LinearInterpolateGrad().apply((p, x, y, g)) | ||
| gz, = grad_outputs | ||
| return LinearInterpolateGrad().apply((p, x, y, gz)) | ||
|
|
||
|
|
||
| class LinearInterpolateGrad(function_node.FunctionNode): |
There was a problem hiding this comment.
I'd like to use the same name for an input in forward and backward. (g vs gz)
|
Thank you for your review. I've made some changes according to your comments. Please confirm. |
|
jenkins, test this please |
okuta
added
cat:enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the source code and the slides about double backprop., it seems a common practice to use
gxandggxto represent the gradients wrtxandgx.However, some variables have contradictory names to this convention and new users may get confused about it. I hope they will be fixed by this PR.