Fix temporary file permission issue in LogReport #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
force-pushed
the
tempfile-permission-log-report
branch
from
fa9b4b3
to
6ca4514
Compare
okuta
added
cat:enhancement
|
LGTM! |
kmaehashi
reviewed
Mar 29, 2018
chainer/utils/__init__.py
Outdated
| try: | ||
| yield temp_dir | ||
| finally: | ||
| shutil.rmtree(temp_dir, ignore_errors=True) |
There was a problem hiding this comment.
Is it safe to ignore errors? (c.f. tempfile.TemporaryDirectory raise error when failure of cleanup: https://github.com/python/cpython/blob/3.6/Lib/tempfile.py#L777-L811)
There was a problem hiding this comment.
I agree.
I made it optional and False by default.
|
LGTM! @okuta Test passed. Could you merge? |
kmaehashi
pushed a commit
to kmaehashi/chainer
that referenced
this pull request
Apr 17, 2018
…report Fix temporary file permission issue in LogReport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the same issue as #4461.
This kind of use of temporary directory is very common, so I made a context manager as
utils.tempdir(), and applied to all such instances.