Initialize gradient of uninitialized parameter with default dtype when initializer is callable #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n initializer is callable
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 63f2466) failed with status FAILURE. |
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 63f2466) succeeded without errors! |
okuta
added
the
st:test-and-merge
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up #4510.
The gradient of an uninitialized parameter was always initialized with NaN of
numpy.float32when its initializer was a callable, in contrast to its data that was initialized with the default dtype. This caused mismatch of dtypes between the data and the gradient.This PR fixes it to use the default dtype to initialize the gradient in such case so that the data and the gradient have the same dtype.