Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial fix for parameterized test case of F.contrastive #5147

Merged
merged 1 commit into from Jul 26, 2018
Merged

Trivial fix for parameterized test case of F.contrastive #5147

merged 1 commit into from Jul 26, 2018

Conversation

takagi
Copy link
Member

@takagi takagi commented Jul 25, 2018

This PR fixes a parameterized test case of F.contrastive. The case was introduced in #3466 .

@takagi takagi added the cat:test Test or CI related. label Jul 25, 2018
@kmaehashi
Copy link
Member

Jenkins, test this please.

@kmaehashi kmaehashi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Jul 25, 2018
@kmaehashi kmaehashi self-assigned this Jul 25, 2018
@kmaehashi kmaehashi added this to the v5.0.0b4 milestone Jul 25, 2018
@kmaehashi kmaehashi added the to-be-backported Pull request that should be backported. label Jul 25, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit ce5d0f6, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@kmaehashi
Copy link
Member

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit ce5d0f6, target branch master) succeeded!

@kmaehashi kmaehashi merged commit c09441d into chainer:master Jul 26, 2018
@kmaehashi
Copy link
Member

LGTM!

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

3 similar comments
@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@kmaehashi kmaehashi mentioned this pull request Aug 21, 2018
Merged
kmaehashi added a commit to kmaehashi/chainer that referenced this pull request Aug 21, 2018
@kmaehashi
Merge pull request chainer#5147 from takagi/fix-contrastive-test
4d4fb38 
Trivial fix for parameterized test case of F.contrastive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kmaehashi kmaehashi

Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v5.0.0b4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takagi @kmaehashi @chainer-ci