Improve type check messages for some functions #5251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 75ac4dc, target branch master) failed with status FAILURE. |
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 75ac4dc, target branch master) succeeded! |
okuta
requested changes
Aug 29, 2018
| @@ -54,7 +54,7 @@ class SLSTM(function.Function): | |||
| """ | |||
|
|
|||
| def check_type_forward(self, in_types): | |||
| type_check.expect(in_types.size() == 4) | |||
| type_check.argname(in_types, ('c1', 'c2', 'x1', 'x2')) | |||
There was a problem hiding this comment.
Why do not use c_prev1, c_prev2 ?
okuta
approved these changes
Aug 30, 2018
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #4969 .