Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log_softmax in D.Categorical #5255

Merged
merged 1 commit into from Aug 28, 2018

Conversation

toslunar
Copy link
Member

Use #5215 to improve #5028 (comment)

@toslunar toslunar added the cat:enhancement Implementation that does not break interfaces. label Aug 21, 2018
@okuta okuta added this to the v5.0.0b5 milestone Aug 28, 2018
@okuta okuta self-assigned this Aug 28, 2018
@okuta
Copy link
Member

okuta commented Aug 28, 2018

LGTM!

@okuta okuta merged commit 5e2b104 into chainer:master Aug 28, 2018
@okuta
Copy link
Member

okuta commented Aug 28, 2018

jenkins, test this please.

@toslunar toslunar deleted the categorical-logsoftmax branch August 28, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants