Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check optional dependencies at runtime #5425

Merged
merged 3 commits into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@kmaehashi
Copy link
Member

commented Oct 4, 2018

Optional dependencies should not be decleared as requirements, as it makes difficult for users to uninstall the optional dependencies.

One of the common pitfall (when user upgraded their CUDA version):

pip install cupy-cuda90
pip install chainer
# -> pip recognizes the dependency from chainer to cupy-cuda90

pip uninstall cupy-cuda90
pip install cupy-cuda92

pip install chainer
# -> pip tries to "fix" broken dependency, causing installation of cupy-cuda90
@kmaehashi

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2018

Jenkins, test this please.

@chainer-ci

This comment has been minimized.

Copy link
Collaborator

commented Oct 4, 2018

Jenkins CI test (for commit caea4ee, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@takagi takagi self-assigned this Oct 5, 2018

@takagi

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

Jenkins, test this please.

@takagi

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

Would you check the CI failure on Travis?

@chainer-ci

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2018

Jenkins CI test (for commit 12df749, target branch master) succeeded!

@kmaehashi

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2018

Fixed. (I'm unsure why it does not fail on Py3.x, though...)

@takagi

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

LGTM!

@takagi takagi merged commit b8d474f into chainer:master Oct 11, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

takagi added a commit to takagi/chainer that referenced this pull request Oct 11, 2018

Merge pull request chainer#5425 from kmaehashi/optional-deps
Check optional dependencies at runtime

@takagi takagi added this to the v6.0.0a1 milestone Oct 11, 2018

@kmaehashi kmaehashi deleted the kmaehashi:optional-deps branch Oct 19, 2018

takagi added a commit that referenced this pull request Nov 2, 2018

Merge pull request #5532 from kmaehashi/add-setuptools
Require setuptools and add docs for #5425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.