New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check optional dependencies at runtime #5425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmaehashi
added
cat:install
Build and installation.
to-be-backported
Pull request that should be backported.
labels
Oct 4, 2018
This was referenced Oct 4, 2018
Jenkins, test this please. |
Jenkins CI test (for commit caea4ee, target branch master) failed with status FAILURE. |
Jenkins, test this please. |
Would you check the CI failure on Travis? |
Jenkins CI test (for commit 12df749, target branch master) succeeded! |
Fixed. (I'm unsure why it does not fail on Py3.x, though...) |
LGTM! |
takagi
added a commit
to takagi/chainer
that referenced
this pull request
Oct 11, 2018
Check optional dependencies at runtime
takagi
added a commit
that referenced
this pull request
Nov 2, 2018
Require setuptools and add docs for #5425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional dependencies should not be decleared as requirements, as it makes difficult for users to uninstall the optional dependencies.
One of the common pitfall (when user upgraded their CUDA version):