Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support negative axis for F.softmax #5497

Merged
merged 5 commits into from Oct 21, 2018
Merged

Conversation

toslunar
Copy link
Member

Merge #5496 first.

This PR also allows 1-dim inputs.

cf. #5381

@toslunar toslunar added the cat:enhancement Implementation that does not break interfaces. label Oct 15, 2018
@toslunar
Copy link
Member Author

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit d15b1f1, target branch master) succeeded!

@okuta okuta added this to the v6.0.0a1 milestone Oct 21, 2018
@okuta okuta self-assigned this Oct 21, 2018
@okuta okuta added the to-be-backported Pull request that should be backported. label Oct 21, 2018
@okuta
Copy link
Member

okuta commented Oct 21, 2018

LGTM!

@okuta okuta merged commit 896966f into chainer:master Oct 21, 2018
okuta added a commit to okuta/chainer that referenced this pull request Oct 21, 2018
Support negative `axis` for `F.softmax`
@toslunar toslunar deleted the softmax-axis branch October 21, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants