Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Use arr.item() instead of np.asscalar(arr) to support NumPy 1.16 #5529

Merged
merged 1 commit into from Oct 19, 2018
Merged

[backport] Use arr.item() instead of np.asscalar(arr) to support NumPy 1.16 #5529

merged 1 commit into from Oct 19, 2018

Conversation

kmaehashi
Copy link
Member

Backport of #5510

@kmaehashi
Merge pull request chainer#5510 from toslunar/np116-asscalar
71fa62a 
Use arr.item() instead of np.asscalar(arr) to support NumPy 1.16
@kmaehashi kmaehashi added backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces. labels Oct 19, 2018
@kmaehashi
Copy link
Member Author

[automatic post] Jenkins, test this please.

toslunar
toslunar approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar added this to the v5.0.0 milestone Oct 19, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 71fa62a, target branch v5) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@toslunar
Copy link
Member

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 71fa62a, target branch v5) succeeded!

@toslunar toslunar self-assigned this Oct 19, 2018
@toslunar toslunar merged commit ae27cb9 into chainer:v5 Oct 19, 2018
@kmaehashi kmaehashi deleted the bp-5510-np116-asscalar branch October 23, 2018 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmaehashi @chainer-ci @toslunar