Add gradient consistency checks in numerical_grad
#5698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuta
added
cat:enhancement
|
jenkins, test this please. |
|
Jenkins CI test (for commit 0fdb8d5, target branch master) succeeded! |
|
LGTM! |
okuta
added a commit
to okuta/chainer
that referenced
this pull request
Nov 25, 2018
Add gradient consistency checks in `numerical_grad`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some consistency checks between
grad_outputsand function outputs innumerical_grad.Fixed some tests accordingly.