Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Remove some CI requirements #5920

Closed
wants to merge 1 commit into from
Closed

[backport] Remove some CI requirements #5920

wants to merge 1 commit into from

Conversation

okuta
Copy link
Member

@okuta okuta commented Dec 24, 2018

Backport of #5865

@okuta
Copy link
Member Author

okuta commented Dec 24, 2018

[automatic post] Jenkins, test this please.

@okuta okuta added backport Pull request that is backported from a more recent version. cat:test Test or CI related. labels Dec 24, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 217f391, target branch v5) succeeded!

@niboshi
Copy link
Member

niboshi commented Dec 24, 2018

I think we don't have to backport this fix.

@okuta
Copy link
Member Author

okuta commented Dec 24, 2018

OK.

@okuta okuta closed this Dec 24, 2018
@niboshi niboshi added this to the Closed issues and PRs milestone Dec 25, 2018
@toslunar
Copy link
Member

toslunar commented Jan 8, 2019

I'd merge this backport PR to fix Travis failure due to version requirements of pytest-cov.

@niboshi
Copy link
Member

niboshi commented Jan 8, 2019

How about restricting to pytest-cov<=2.6.0 instead?
We should be careful about changing requirements (even removal) in the stable branch.
pytest-cov 2.6.1 was released just a day ago, so it should be relatively safer to change pytest-cov to pytest-cov<=2.6.0.

...But as they're requirements for travis and appveyor, it's unlikely that any third-party depend on it.
So it's not a strong opinion.

@okuta okuta reopened this Jan 8, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 217f391, target branch v5) succeeded!

@niboshi niboshi mentioned this pull request Jan 9, 2019
Merged
@niboshi
Copy link
Member

niboshi commented Jan 9, 2019

#5968 has been merged.

@niboshi niboshi closed this Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
backport Pull request that is backported from a more recent version. cat:test Test or CI related.
Projects
None yet
Milestone
Closed issues and PRs
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@okuta @chainer-ci @niboshi @toslunar