Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iterator syntax in MNIST custom loop example #6099

Merged
merged 1 commit into from Jan 29, 2019
Merged

Fix iterator syntax in MNIST custom loop example #6099

merged 1 commit into from Jan 29, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Jan 27, 2019

For consistency with other examples.

@niboshi niboshi added the cat:example Example, e.g. the MNIST example. label Jan 27, 2019
@mitmul mitmul self-assigned this Jan 29, 2019
@mitmul
Copy link
Member

mitmul commented Jan 29, 2019

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2a2a1ff, target branch master) succeeded!

@kmaehashi
Copy link
Member

Related to: #4155, #5519

@niboshi niboshi added the to-be-backported Pull request that should be backported. label Jan 29, 2019
@mitmul
Copy link
Member

mitmul commented Jan 29, 2019

LGTM

@mitmul mitmul merged commit 2cfba2a into chainer:master Jan 29, 2019
@niboshi niboshi deleted the example-iter-syntax branch January 29, 2019 05:57
@chainer-ci
Copy link
Member

@mitmul This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@niboshi niboshi added this to the v6.0.0b3 milestone Feb 4, 2019
@chainer-ci
Copy link
Member

@mitmul This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

2 similar comments
@chainer-ci
Copy link
Member

@mitmul This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@chainer-ci
Copy link
Member

@mitmul This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@niboshi
Copy link
Member Author

niboshi commented Feb 27, 2019

@mitmul Can you make a backport PR?

@chainer-ci
Copy link
Member

@mitmul This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

3 similar comments
@chainer-ci
Copy link
Member

@mitmul This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@chainer-ci
Copy link
Member

@mitmul This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@chainer-ci
Copy link
Member

@mitmul This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

kmaehashi pushed a commit to kmaehashi/chainer that referenced this pull request Mar 18, 2019
@mitmul @kmaehashi
Merge pull request chainer#6099 from niboshi/example-iter-syntax
542c11f 
Fix iterator syntax in MNIST custom loop example
@kmaehashi kmaehashi mentioned this pull request Mar 18, 2019
Merged
@kmaehashi
Copy link
Member

I made a backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mitmul mitmul

Labels
cat:example Example, e.g. the MNIST example. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v6.0.0b3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@niboshi @mitmul @chainer-ci @kmaehashi