Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Avoid using pytest attributes during import #6470

Merged
merged 1 commit into from Mar 11, 2019
Merged

[backport] Avoid using pytest attributes during import #6470

merged 1 commit into from Mar 11, 2019

Conversation

Crissman
Copy link
Member

@Crissman Crissman commented Mar 8, 2019

Backport of #6453

@Crissman
Merge pull request chainer#6453 from kmaehashi/fix-pytest-mark
976a4a4 
Avoid using pytest attributes during import
@Crissman Crissman added backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces. labels Mar 8, 2019
@Crissman
Copy link
Member Author

Crissman commented Mar 8, 2019

[automatic post] Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 976a4a4, target branch v5) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

toslunar
toslunar approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar added this to the v5.4.0 milestone Mar 8, 2019
@toslunar toslunar merged commit 7821c66 into chainer:v5 Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Crissman @chainer-ci @toslunar