Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use intermediate dtype in F.mean_absolute_error for FP16 #6807

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Use intermediate dtype in F.mean_absolute_error for FP16 #6807

merged 3 commits into from
Nov 19, 2019

Conversation

takagi
Copy link
Member

@takagi takagi commented Apr 9, 2019

Close #6702.

This PR fixes F.mean_absolute_error to use an intermediate dtype for FP16 inputs. numpy.mean is not used because old numpy does not use extra precision for FP16.

https://docs.scipy.org/doc/numpy-1.9.2/reference/generated/numpy.mean.html
https://docs.scipy.org/doc/numpy-1.16.1/reference/generated/numpy.mean.html

@takagi takagi added the cat:enhancement Implementation that does not break interfaces. label Apr 9, 2019
@takagi takagi force-pushed the dtype-mean-absolute-error branch from db12447 to 007b438 Compare May 8, 2019 07:01
@takagi takagi force-pushed the dtype-mean-absolute-error branch from 007b438 to 1d274c0 Compare May 24, 2019 06:14
@kmaehashi
Copy link
Member

pfnCI, test this please.

kmaehashi
kmaehashi approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmaehashi kmaehashi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Jun 13, 2019
@kmaehashi kmaehashi added this to the v7.0.0b1 milestone Jun 13, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit a8874a3, target branch master) failed with status FAILURE.

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 4 days. Could you check?

@emcastillo emcastillo removed this from the v7.0.0b1 milestone Jun 21, 2019
@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

15 similar comments
@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

18 similar comments
@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 4 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

4 similar comments
@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 6 days. Could you check?

@kmaehashi
Copy link
Member

pfnCI, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit a8874a3, target branch master) succeeded!

@mergify mergify bot merged commit e94ac64 into chainer:master Nov 19, 2019
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi kmaehashi approved these changes

Assignees

@kmaehashi kmaehashi

Labels
cat:enhancement Implementation that does not break interfaces. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

F.mean_absolute_error numerically unstable with float16 arrays
4 participants
@takagi @kmaehashi @chainer-ci @emcastillo