Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning filter for protobuf #7715

Merged
merged 1 commit into from Jul 10, 2019
Merged

Fix warning filter for protobuf #7715

merged 1 commit into from Jul 10, 2019

Conversation

toslunar
Copy link
Member

@toslunar toslunar commented Jul 5, 2019

This PR tries to address #7433.

@toslunar toslunar added the cat:test Test or CI related. label Jul 5, 2019
emcastillo
emcastillo approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emcastillo
Copy link
Member

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 3756b4c, target branch master) failed with status FAILURE.

@toslunar
Copy link
Member Author

toslunar commented Jul 9, 2019

The failures look unrelated to the PR.

FAIL repo/tests/chainerx_tests/unit_tests/routines_tests/test_trigonometric_hyperbolic.py::test_Arcsin_param_203_{contiguous='C', in_dtypes=('float64',), out_dtype='float64', input=-0.9, shape=(2, 3)}[cuda:0]
FAIL ../../repo/tests/chainer_tests/functions_tests/normalization_tests/test_decorrelated_batch_normalization.py::TestDecorrelatedBatchNormalization_use_chainerx_false__chainerx_device_None__use_cuda_true__cuda_device_0__use_cudnn_never__cudnn_deterministic_false__autotune_false__cudnn_fast_batch_normalization_false__use_ideep_never_param_24_{contiguous=None, dtype=float32, eps=2e-05, groups=1, n_channels=8, ndim=1}::test_forward

@emcastillo emcastillo added this to the v7.0.0b2 milestone Jul 10, 2019
@emcastillo
Copy link
Member

@toslunar should we backport?

@toslunar
Copy link
Member Author

@toslunar should we backport?

Yes.

@toslunar toslunar added the to-be-backported Pull request that should be backported. label Jul 10, 2019
@emcastillo emcastillo merged commit b899db4 into chainer:master Jul 10, 2019
@emcastillo emcastillo mentioned this pull request Jul 10, 2019
Merged
emcastillo pushed a commit to emcastillo/chainer that referenced this pull request Jul 10, 2019
Merge pull request chainer#7715 from toslunar/ignore-protobuf-warn-py37
99b4222 
Fix warning filter for protobuf
@toslunar toslunar deleted the ignore-protobuf-warn-py37 branch July 10, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emcastillo emcastillo emcastillo approved these changes

Assignees

@emcastillo emcastillo

Labels
cat:test Test or CI related. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v7.0.0b2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toslunar @emcastillo @chainer-ci