Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Make F.average as accurate as backend #7782

Merged
merged 1 commit into from Jul 20, 2019
Merged

[backport] Make F.average as accurate as backend #7782

merged 1 commit into from Jul 20, 2019

Conversation

emcastillo
Copy link
Member

Backport of #7758

Merge pull request chainer#7758 from toslunar/fix-average-overflow
f95dfbb 
Make `F.average` as accurate as backend
@emcastillo
Copy link
Member Author

[automatic post] Jenkins, test this please.

@emcastillo emcastillo added backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces. labels Jul 20, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit f95dfbb, target branch v6) failed with status FAILURE.

@toslunar toslunar self-assigned this Jul 20, 2019
toslunar
toslunar approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar added this to the v6.3.0 milestone Jul 20, 2019
@toslunar toslunar merged commit 001aa7e into chainer:v6 Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Milestone
v6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emcastillo @chainer-ci @toslunar