Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in test_communicator #7822

Merged
merged 1 commit into from Jul 30, 2019
Merged

Fix a typo in test_communicator #7822

merged 1 commit into from Jul 30, 2019

Conversation

belldandyxtq
Copy link
Member

This commit fixes a typo in test_communicator which causes the nccl
communicator in non_cuda_aware_communicator cannot be identified and destroyed.

@belldandyxtq
Fix a typo in test_communicator
0304389 
This commit fixes a typo in test_communicator which causes the nccl
communicator in non_cuda_aware_communicator cannot be identified and destroyed.
@belldandyxtq belldandyxtq added cat:bug Bug report or fix. cat:test Test or CI related. ChainerMN Related to ChainerMN. labels Jul 29, 2019
@kuenishi kuenishi removed the cat:bug Bug report or fix. label Jul 29, 2019
kuenishi
kuenishi approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@kuenishi kuenishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sort of backport; #7814 minus new API .

@kuenishi
Copy link
Member

/test

@kuenishi kuenishi added this to the v6.3.0 milestone Jul 29, 2019
@kuenishi kuenishi merged commit 3810582 into chainer:v6 Jul 30, 2019
@belldandyxtq belldandyxtq deleted the fix_typo branch August 8, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuenishi kuenishi kuenishi approved these changes

Assignees
No one assigned
Labels
cat:test Test or CI related. ChainerMN Related to ChainerMN.
Projects
None yet
Milestone
v6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@belldandyxtq @kuenishi