Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax float16 tolerances in ChainerX binary math tests #7874

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Relax float16 tolerances in ChainerX binary math tests #7874

merged 1 commit into from
Aug 8, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Aug 7, 2019 •
edited
Loading

Fixes #7845

pytest --count 1000  -s -v -rfEX --tb=short tests/chainerx_tests/unit_tests/routines_tests/test_arithmetic.py -k '_Sub_ and float16 and cuda'

Before: 7 failed, 59993 passed, 26690000 deselected in 4267.15 seconds
After fix: 60000 passed, 26690000 deselected in 4166.01 seconds

@niboshi niboshi changed the title Configure tolerances in chainerx.subtract test Configure tolerances in chainerx.subtract test Aug 7, 2019
@niboshi niboshi added cat:test Test or CI related. prio:high High priority. Urgent and needs to be worked on as soon as possible. to-be-backported Pull request that should be backported. labels Aug 7, 2019
@asi1024 asi1024 self-assigned this Aug 7, 2019
@niboshi niboshi mentioned this pull request Aug 7, 2019
Closed
@asi1024
Copy link
Member

asi1024 commented Aug 7, 2019

pfnCI, test this please.

@asi1024 asi1024 added this to the v7.0.0b3 milestone Aug 7, 2019
@niboshi niboshi changed the title Configure tolerances in chainerx.subtract test Relax float16 tolerances in ChainerX binary math tests Aug 7, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 401bcf8, target branch master) failed with status FAILURE.

@asi1024
Copy link
Member

asi1024 commented Aug 8, 2019

Jenkins failure seems unrelated to this PR. LGTM.

@asi1024 asi1024 merged commit ac25ec5 into chainer:master Aug 8, 2019
@niboshi niboshi deleted the test-tolerance-arithmetic branch August 8, 2019 05:09
@chainer-ci
Copy link
Member

@asi1024 This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@asi1024 asi1024 mentioned this pull request Aug 12, 2019
Merged
asi1024 added a commit to asi1024/chainer that referenced this pull request Aug 12, 2019
@asi1024
Merge pull request chainer#7874 from niboshi/test-tolerance-arithmetic
6698571 
Relax float16 tolerances in ChainerX binary math tests
This was referenced Aug 13, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asi1024 asi1024

Labels
cat:test Test or CI related. prio:high High priority. Urgent and needs to be worked on as soon as possible. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v7.0.0b3
Development

Successfully merging this pull request may close these issues.

flaky test: chainerx_tests/unit_tests/routines_tests/test_arithmetic.py::test_Sub
3 participants
@niboshi @asi1024 @chainer-ci