-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alex Graves's RMSprop (#48 reopened) #82
Conversation
Thanks! I will check this PR again. |
ba74c3c
to
a1be84f
Compare
import numpy | ||
|
||
from chainer import cuda | ||
from chainer import Optimizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style does not admit direct import of Classes (only modules are permitted). So please import chainer.optimizer
instead of Optimizer
.
I check the code. It looks OK except one import statement. |
from chainer import Optimizer | ||
|
||
|
||
class RMSpropGraves(Optimizer): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In response to the above comment, please fix here, too.
OK, I fixed the import sentence. |
LGTM 👍 |
Alex Graves's RMSprop (#48 reopened)
Deterministic test
This PR adds a new optimizer, RMSpropGraves, which is an RMSprop variation proposed by Alex Graves in http://arxiv.org/abs/1308.0850 and used in some papers from Google DeepMind including http://www.nature.com/nature/journal/v518/n7540/abs/nature14236.html?lang=en and http://arxiv.org/abs/1410.5401.
(This PR is the same as #48 except for adding unit tests)