Alex Graves's RMSprop (#48 reopened) #82
Merged
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I will check this PR again. |
muupan
force-pushed
the
rmsprop-graves
branch
2 times, most recently
from
ba74c3c
to
a1be84f
Compare
| import numpy | ||
|
|
||
| from chainer import cuda | ||
| from chainer import Optimizer |
There was a problem hiding this comment.
Coding style does not admit direct import of Classes (only modules are permitted). So please import chainer.optimizer instead of Optimizer.
|
I check the code. It looks OK except one import statement. |
| from chainer import Optimizer | ||
|
|
||
|
|
||
| class RMSpropGraves(Optimizer): |
There was a problem hiding this comment.
In response to the above comment, please fix here, too.
|
OK, I fixed the import sentence. |
|
LGTM 👍 |
delta2323
added a commit
that referenced
this pull request
Jun 30, 2015
Alex Graves's RMSprop (#48 reopened)
okuta
added a commit
to okuta/chainer
that referenced
this pull request
Jul 14, 2017
Deterministic test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new optimizer, RMSpropGraves, which is an RMSprop variation proposed by Alex Graves in http://arxiv.org/abs/1308.0850 and used in some papers from Google DeepMind including http://www.nature.com/nature/journal/v518/n7540/abs/nature14236.html?lang=en and http://arxiv.org/abs/1410.5401.
(This PR is the same as #48 except for adding unit tests)