Forward chainerx::MakeArray in some case #8296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you explain a bit more? For what case this fix is needed? |
|
Updated the PR comment |
niboshi
requested changes
Oct 17, 2019
chainerx_cc/chainerx/python/array.cc
Outdated
| if (!copy && py::isinstance<ArrayBody>(object)) { | ||
| ArrayBodyPtr body = py::cast<ArrayBodyPtr>(object); | ||
| if ((device.is_none() || &dev == &body->device()) && (dtype.is_none() || *dtype_ == body->dtype())) { | ||
| return std::move(body); |
There was a problem hiding this comment.
I think you don't have to move the return value.
| @@ -259,10 +259,14 @@ def test_array_from_chainerx_array_with_device( | |||
|
|
|||
| dst_device = chainerx.get_device(dst_device_spec) | |||
|
|
|||
| if not copy and src_dtype == dst_dtype and device is dst_device: | |||
| if not copy and \ | |||
There was a problem hiding this comment.
Let's follow the recommendation in PEP-8.
- Use parentheses instead of
\. - Place
andafter line breaks.
|
I think |
|
Sorry never mind, the above comment only assumed the default |
|
Jenkins, test this please |
|
Jenkins CI test (for commit d5a9a6b, target branch master) failed with status FAILURE. |
|
Jenkins, test this please |
emcastillo
added
cat:enhancement
|
Jenkins CI test (for commit d5a9a6b, target branch master) succeeded! |
niboshi
approved these changes
Oct 30, 2019
|
LGTM @emcastillo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin-offed from: #8262
In non-copy mode of more C++ like
MakeArrayif device and dtype matches the source array so python like API should follow the behavior too:chainer/chainerx_cc/chainerx/python/array.cc
Lines 153 to 155 in 49b6941
TODO: