Raise ValueError when calling xxx_obj with ChainerX array in ChainerMN
#8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belldandyxtq
added
contribution-welcome
The chainerx array preserves device id inside, which will also be pickled during the mpi communications and causes future errors. This commit prevent such cases by raising ValueError when calling `x_obj` with the chainerx array.
belldandyxtq
force-pushed
the
mpi_obj_chainerx
branch
from
0ad860a
to
d9e2244
Compare
belldandyxtq
force-pushed
the
mpi_obj_chainerx
branch
from
d9e2244
to
0d10a8e
Compare
belldandyxtq
removed
the
contribution-welcome
|
Jenkins, test this please |
shu65
reviewed
Nov 14, 2019
| xp = chainer.backend.get_array_module(value) | ||
| if xp == chainerx and value.device.name.startswith('cuda'): | ||
| return True | ||
| else: |
There was a problem hiding this comment.
How about checking if obj is array object of numpy, 'cupy', and chainerx?
There was a problem hiding this comment.
chainer.backend.get_array_module can accept any type and return numpy for types that are not cupy nor chainerx. So I don't think we have to check if they beforehand.
|
Jenkins CI test (for commit 0d10a8e, target branch master) succeeded! |
|
Jenkins, test this please |
|
Jenkins CI test (for commit e7dc04d, target branch master) succeeded! |
shu65
approved these changes
Nov 14, 2019
kmaehashi
added
the
cat:enhancement
emcastillo
changed the title
xxx_obj with ChainerX array in ChianerMNxxx_obj with ChainerX array in ChainerMN
|
Jenkins CI test (for commit e7dc04d, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chainerx array preserves device id inside, which will also be
pickled during the mpi communications and causes future errors.
This PR prevents such cases by raising ValueError when calling
x_objwith the chainerx array.