Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onnx_chainer's exporter of Separate to handle single output case #8332

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

msakai
Copy link
Contributor

@msakai msakai commented Oct 29, 2019

This PR fixes IndexError: list index out of range when the Separate node has only single output.

@emcastillo emcastillo added the ONNX Related to ONNX label Oct 29, 2019
Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@take-cheeze take-cheeze self-assigned this Oct 29, 2019
@take-cheeze take-cheeze added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Oct 29, 2019
@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 86c66f2, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

Flaky?
Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 86c66f2, target branch master) succeeded!

@mergify mergify bot merged commit 273b533 into chainer:master Oct 29, 2019
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
@kmaehashi kmaehashi added the cat:bug Bug report or fix. label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:bug Bug report or fix. ONNX Related to ONNX st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants