Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple advanced indexing on ONNX export #8345

Merged
merged 6 commits into from
Oct 31, 2019
Merged

Support multiple advanced indexing on ONNX export #8345

merged 6 commits into from
Oct 31, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Oct 30, 2019 •
edited

Using GatherND operator, added from upset11. Please merge #8341 first. <- merged, thx

@disktnk disktnk added the ONNX Related to ONNX label Oct 30, 2019
@disktnk disktnk mentioned this pull request Oct 30, 2019
Closed
@disktnk disktnk marked this pull request as ready for review October 30, 2019 13:47
shinh
shinh approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

onnx_chainer/functions/array.py Outdated Show resolved Hide resolved
onnx_chainer/functions/array.py Outdated Show resolved Hide resolved
@take-cheeze take-cheeze self-assigned this Oct 31, 2019
take-cheeze
take-cheeze approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@take-cheeze take-cheeze added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Oct 31, 2019
@take-cheeze
Copy link
Member

Jenkins test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 1d4e72d, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

Jenkins test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 1d4e72d, target branch master) succeeded!

@take-cheeze
Copy link
Member

Seems travis status isn't notified to github.
Merging

@take-cheeze take-cheeze merged commit 70ff0d9 into chainer:master Oct 31, 2019
@disktnk disktnk deleted the fix/multi-advanced-idx branch October 31, 2019 05:08
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
@kmaehashi kmaehashi added the cat:enhancement Implementation that does not break interfaces. label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinh shinh shinh approved these changes

@take-cheeze take-cheeze take-cheeze approved these changes

Assignees

@take-cheeze take-cheeze

Labels
cat:enhancement Implementation that does not break interfaces. ONNX Related to ONNX st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@disktnk @take-cheeze @chainer-ci @shinh @kmaehashi