Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert output value check in SoftmaxCrossEntropy #8347

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Revert output value check in SoftmaxCrossEntropy #8347

merged 1 commit into from
Oct 31, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Oct 30, 2019

latest ONNXRuntime supports float type inputs (ref:microsoft/onnxruntime#1537) on OntHot, don't have to skip them.

@disktnk disktnk added the ONNX Related to ONNX label Oct 30, 2019
@take-cheeze
Copy link
Member

Jenkins, test this please!

@take-cheeze take-cheeze self-assigned this Oct 30, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 221e16c, target branch master) succeeded!

shinh
shinh approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

take-cheeze
take-cheeze approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@take-cheeze take-cheeze added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Oct 31, 2019
@mergify mergify bot merged commit 93a5469 into chainer:master Oct 31, 2019
@disktnk disktnk deleted the fix/onehot-check branch October 31, 2019 02:05
@disktnk disktnk mentioned this pull request Nov 7, 2019
Closed
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
@kmaehashi kmaehashi added the cat:enhancement Implementation that does not break interfaces. label Dec 5, 2019
@emcastillo emcastillo changed the title Revert output value check on SoftmaxCrossEntropy Revert output value check on SoftmaxCrossEntropy Dec 5, 2019
@emcastillo emcastillo changed the title Revert output value check on SoftmaxCrossEntropy Revert output value check in SoftmaxCrossEntropy Dec 5, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 221e16c, target branch master) failed with status FAILURE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinh shinh shinh approved these changes

@take-cheeze take-cheeze take-cheeze approved these changes

Assignees

@take-cheeze take-cheeze

Labels
cat:enhancement Implementation that does not break interfaces. ONNX Related to ONNX st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@disktnk @take-cheeze @chainer-ci @shinh @kmaehashi