Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print installed packages in pytest #8348

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Print installed packages in pytest #8348

merged 1 commit into from
Nov 7, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Oct 31, 2019 •
edited
Loading

To make investigation easier.

@niboshi niboshi added cat:test Test or CI related. to-be-backported Pull request that should be backported. labels Oct 31, 2019
@niboshi niboshi force-pushed the test-print-installed-packages branch 2 times, most recently from 19d96d2 to f4ad2bd Compare October 31, 2019 03:44
@niboshi niboshi force-pushed the test-print-installed-packages branch from f4ad2bd to b4814d2 Compare October 31, 2019 06:10
@niboshi
Copy link
Member Author

niboshi commented Oct 31, 2019

Introduced CHAINER_CI.
Packages are printed only when its value is non-empty.

PTAL

This was referenced Oct 31, 2019
Merged
Merged
Merged
@takagi takagi self-requested a review November 5, 2019 06:06
@takagi
Copy link
Member

takagi commented Nov 5, 2019

Jenkins, test this please.

@takagi takagi added this to the v7.0.0 milestone Nov 5, 2019
@takagi takagi assigned takagi and unassigned kmaehashi Nov 5, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit b4814d2, target branch master) succeeded!

@takagi
Copy link
Member

takagi commented Nov 5, 2019

Required CI failure on ChainerX Cholesky, essentially unrelated to this PR.

@takagi
Copy link
Member

takagi commented Nov 5, 2019

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit b4814d2, target branch master) succeeded!

@takagi
Copy link
Member

takagi commented Nov 7, 2019 •
edited
Loading

LGTM! I also checked it on my local.

@takagi takagi merged commit 5d38282 into chainer:master Nov 7, 2019
@niboshi niboshi deleted the test-print-installed-packages branch November 7, 2019 02:00
@niboshi
Copy link
Member Author

niboshi commented Nov 7, 2019

Thanks!

@takagi takagi mentioned this pull request Nov 7, 2019
Merged
takagi added a commit to takagi/chainer that referenced this pull request Nov 7, 2019
@takagi
Merge pull request chainer#8348 from niboshi/test-print-installed-pac…
f03b806 
…kages

Print installed packages in pytest
@niboshi niboshi mentioned this pull request Jan 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takagi takagi Awaiting requested review from takagi

Assignees

@takagi takagi

Labels
cat:test Test or CI related. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@niboshi @takagi @chainer-ci @kmaehashi