Enhance chainerx::AddAt as a public function
#8351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Throw exceptions instead of assertion - Fix function comment - Rename AddAt as a backward of At to AtGrad, as it's confusing that the two functions have the same name.
niboshi
changed the title
chainerx::AddAt as a public function
|
Jenkins, test this please! |
|
Jenkins CI test (for commit bf50751, target branch master) failed with status FAILURE. |
|
Jenkins, test this please! |
|
Jenkins CI test (for commit bf50751, target branch master) failed with status FAILURE. |
|
Jenkins, test this please! |
|
Jenkins CI test (for commit bf50751, target branch master) succeeded! |
take-cheeze
added
the
st:test-and-merge
kmaehashi
added
the
cat:enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddAtas a backward ofAttoAtGrad, as it's confusing thatthe two functions have the same name.