Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax float16 forward tolerance of F.cast test #8363

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Nov 1, 2019

Fixes #7892

@niboshi niboshi changed the title Relax float16 forward tolerance of F.cast test Relax float16 forward tolerance of F.cast test Nov 1, 2019
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar added cat:test Test or CI related. to-be-backported Pull request that should be backported. labels Nov 1, 2019
@toslunar
Copy link
Member

toslunar commented Nov 1, 2019

Jenkins & flexCI, test this please.

@toslunar toslunar added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 1, 2019
@toslunar toslunar added this to the v7.0.0 milestone Nov 1, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 5e9a94d, target branch master) succeeded!

@mergify mergify bot merged commit 46d3a2b into chainer:master Nov 1, 2019
@niboshi niboshi deleted the test-cast-tol branch November 1, 2019 06:02
@toslunar
Copy link
Member

toslunar commented Nov 1, 2019

#7034 is only in v7.

@toslunar toslunar removed the to-be-backported Pull request that should be backported. label Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: chainer_tests/functions_tests/array_tests/test_cast.py::TestCast
3 participants