-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove typing requirement #8383
Conversation
Thank you for the PR! As for Although v6 series still continues to support Python 2 for some time, I don't think this change has to be backported to v6, because the next v6 release will coincide with v7.0.0 major release. A change of dependency in already-released-as-stable v6, which might cause unexpected problem for existing v6 users, is also a concern about backporting. |
sure, sounds good |
64f9669
to
de95007
Compare
done |
Thanks! |
If active development on master no longer cares for python2.7/3.5 compatibility, you may as well disable the respective CI paths |
Jenkins CI test (for commit de95007, target branch master) failed with status FAILURE. |
We've already done that (Btw, Python 3.5 is still supported). Jenkins failure is unrelated. |
Was packaging this for nixpkgs and noticed some odd import behaviors.
typing
package is a backport and doesn't need to be imported for python>=3.5see python/typing#573