Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove typing requirement #8383

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Remove typing requirement #8383

merged 1 commit into from
Nov 8, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 7, 2019 •
edited

Was packaging this for nixpkgs and noticed some odd import behaviors.

typing package is a backport and doesn't need to be imported for python>=3.5

see python/typing#573

@niboshi niboshi self-assigned this Nov 7, 2019
@niboshi
Copy link
Member

niboshi commented Nov 7, 2019 •
edited

Thank you for the PR!

As for typing dependency, how about simply removing it?
We have already abandoned Python<3.5 support in master (v7 series) branch.

Although v6 series still continues to support Python 2 for some time, I don't think this change has to be backported to v6, because the next v6 release will coincide with v7.0.0 major release. A change of dependency in already-released-as-stable v6, which might cause unexpected problem for existing v6 users, is also a concern about backporting.

@jonringer
Copy link
Contributor Author

sure, sounds good

@jonringer
Copy link
Contributor Author

done

@niboshi
Copy link
Member

niboshi commented Nov 8, 2019

Thanks!
Jenkins, test this please

@niboshi niboshi added this to the v7.0.0 milestone Nov 8, 2019
@niboshi niboshi added cat:install Build and installation. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Nov 8, 2019
@niboshi niboshi changed the title Use environment markers for typing version Remove typing requirement Nov 8, 2019
@jonringer
Copy link
Contributor Author

If active development on master no longer cares for python2.7/3.5 compatibility, you may as well disable the respective CI paths

@chainer-ci
Copy link
Member

Jenkins CI test (for commit de95007, target branch master) failed with status FAILURE.

@niboshi
Copy link
Member

niboshi commented Nov 8, 2019

If active development on master no longer cares for python2.7/3.5 compatibility, you may as well disable the respective CI paths

We've already done that (Btw, Python 3.5 is still supported).
Thanks!

Jenkins failure is unrelated.

@niboshi niboshi merged commit ae3e83d into chainer:master Nov 8, 2019
@jonringer jonringer deleted the fix-typing-versioning branch November 8, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
cat:install Build and installation. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @niboshi @chainer-ci