Add chainerx test in observation_aggregator #8384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2019
keisukefukuda
changed the title
tests/chainermn_tests/extensions_tests/test_observation_aggregator.py
Outdated
Show resolved
Hide resolved
|
Jenkins, test this please! |
|
Jenkins, test this please! |
|
Jenkins CI test (for commit 111cf0b, target branch master) succeeded! |
shu65
reviewed
Dec 12, 2019
belldandyxtq
requested changes
Dec 12, 2019
tests/chainermn_tests/extensions_tests/test_observation_aggregator.py
Outdated
Show resolved
Hide resolved
|
pfnci, test this please. |
|
Jenkins CI test (for commit 97a9918, target branch master) succeeded! |
|
pfnci, test this please. |
|
Jenkins CI test (for commit ee785bc, target branch master) succeeded! |
belldandyxtq
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #8508
This PR is a replacement of #8322 by @belldandyxtq
This PR adds ChainerX tests into the observation_aggregator
This PR partially solves #8031. This PR depends on #8321
NOTE: This PR is completed w.r.t. the code, but it causes SEGV depending on the order of test cases in test_observatgion_aggregator.py. I guess it is because of the behavior of ChainerX's device setting. We need a deeper investigation on this issue.fixed!