Support cover_all=True on Unpooling2D in exporting to ONNX
#8391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins. test this please! |
|
Jenkins CI test (for commit 69d3cc2, target branch master) succeeded! |
shinh
approved these changes
Nov 11, 2019
| @@ -24,6 +24,11 @@ | |||
| 'in_shape': (1, 3, 6, 5, 4), 'args': [3, 2, 1], 'cover_all': True}, | |||
| {'op_name': 'unpooling_2d', | |||
| 'in_shape': (1, 3, 6, 6), 'args': [3, None, 0], 'cover_all': False}, | |||
| # when cover_all=True, interpolation between Chainer and ONNXRuntime | |||
|
Jenkins, test this please! |
take-cheeze
added
the
st:test-and-merge
|
Jenkins CI test (for commit 72a2edc, target branch master) succeeded! |
kmaehashi
added
the
cat:enhancement
emcastillo
changed the title
cover_all=True on Unpooling2D in exporting to ONNX
Closed
|
Jenkins CI test (for commit 72a2edc, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
cover_all=Trueon Chainer'sUnpool2d. Simply recalculate output size. Interpolation logic is differ between Chainer and ONNXRuntime, and output values checking is skipped.