Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsigned suffix in float16 test #8408

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Add unsigned suffix in float16 test #8408

merged 1 commit into from
Nov 13, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Nov 11, 2019

In some cases the suffix is needed to avoid a compiler warning: comparison between signed and unsigned integers.

@niboshi niboshi changed the title Add unsigned prefix in float16 test Add unsigned suffix in float16 test Nov 12, 2019
@niboshi niboshi mentioned this pull request Nov 12, 2019
Merged
emcastillo
emcastillo approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emcastillo
Copy link
Member

Jenkins, test this please

@emcastillo emcastillo added cat:code-fix Code refactoring that does not change the behavior. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Nov 13, 2019
@emcastillo emcastillo added this to the v7.0.0 milestone Nov 13, 2019
@emcastillo emcastillo added the ChainerX Related to ChainerX. label Nov 13, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 342a9d3, target branch master) succeeded!

@mergify mergify bot merged commit 910b58e into chainer:master Nov 13, 2019
@niboshi niboshi mentioned this pull request Nov 13, 2019
Closed
@niboshi niboshi deleted the uint-suffix-float16test branch November 13, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emcastillo emcastillo emcastillo approved these changes

Assignees

@emcastillo emcastillo

Labels
cat:code-fix Code refactoring that does not change the behavior. ChainerX Related to ChainerX. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niboshi @emcastillo @chainer-ci