Avoid repeatedly enumerating submodules #8421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
previously approved these changes
Nov 18, 2019
emcastillo
reviewed
Nov 18, 2019
| target_link_options(chainerx PUBLIC /wholearchive:$<TARGET_FILE:chainerx_routines>) | ||
| target_link_options(chainerx PUBLIC /wholearchive:$<TARGET_FILE:chainerx_native>) | ||
| target_link_options(chainerx PUBLIC /wholearchive:$<TARGET_FILE:chainerx_testing>) | ||
| target_link_libraries(chainerx PRIVATE chainerx_routines) |
There was a problem hiding this comment.
Here chainerx_base was not linked, but on the new changeset, it is.
I am not sure if this might cause any kind of issue in windows.
I don't think it should at all but might be better to confirm it?
There was a problem hiding this comment.
Fixed in afacf69.
Unfortunately I don't have Windows environment to test it.
Although it's better to confirm the fix, we don't necessarily have to do it because Windows is currently not officially supported.
There was a problem hiding this comment.
That sounds perfectly fine to me.
Thanks for addressing it
LGTM then!
emcastillo
approved these changes
Nov 18, 2019
|
Jenkins, test this please |
emcastillo
added
cat:code-fix
|
Jenkins, test this please |
|
Jenkins CI test (for commit afacf69, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a DRY refactoring of
CMakeLists.txt.