Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChainerMN and ONNX-chainer tests to Mergify requirements #8424

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Add ChainerMN and ONNX-chainer tests to Mergify requirements #8424

merged 1 commit into from
Nov 13, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Nov 13, 2019 •
edited
Loading

No description provided.

@niboshi niboshi mentioned this pull request Nov 13, 2019
Closed
@take-cheeze take-cheeze added ONNX Related to ONNX ChainerMN Related to ChainerMN. labels Nov 13, 2019
@kmaehashi kmaehashi added the cat:test Test or CI related. label Nov 13, 2019
take-cheeze
take-cheeze approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! 👍

@kmaehashi
Copy link
Member

Talked with ChainerMN team and agreed on this.

pfnCI, test this please.

@kmaehashi kmaehashi added this to the v7.0.0 milestone Nov 13, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit a420fc3, target branch master) failed with status FAILURE.

@kmaehashi
Copy link
Member

LGTM! Test failures are not related to this PR.

@kmaehashi kmaehashi merged commit e60291c into chainer:master Nov 13, 2019
@niboshi niboshi deleted the mergify-reqs branch November 13, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@take-cheeze take-cheeze take-cheeze approved these changes

Assignees

@kmaehashi kmaehashi

Labels
cat:test Test or CI related. ChainerMN Related to ChainerMN. ONNX Related to ONNX
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@niboshi @kmaehashi @chainer-ci @take-cheeze